feat: skip commit on failures #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taras-zak
reviewed
Sep 9, 2024
| ctx := context.Background() | ||
| err := t.chain.Process(ctx, nil) | ||
| if err != nil { | ||
| t.onError(err) |
There was a problem hiding this comment.
need check if onError is nil, func type in go is nullable
cyberhck
force-pushed
the
idea/no-commit-on-drastic-failure
branch
from
71786aa to
37f40b8
Compare
|
taras-zak
approved these changes
Sep 11, 2024
|
Should you mark PR as contain breaking changes since it changes signature for middlewares ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
Please confirm that you have done the following before requesting reviews:
the Honest Pull Request and Commit Message Naming Conventions.
Description
fixes #94
This change is